From b0e31340b4551d997a8895fd9294b253ddf69dc5 Mon Sep 17 00:00:00 2001 From: Lars-Dominik Braun Date: Sat, 16 Mar 2019 17:16:51 +0100 Subject: browser: Raise exception if navigation failed MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Stop early if there’s nothing to do. --- crocoite/test_browser.py | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) (limited to 'crocoite/test_browser.py') diff --git a/crocoite/test_browser.py b/crocoite/test_browser.py index 7727259..6341bd6 100644 --- a/crocoite/test_browser.py +++ b/crocoite/test_browser.py @@ -34,7 +34,7 @@ import pytest from .browser import RequestResponsePair, SiteLoader, VarChangeEvent, Request, \ UnicodeBody, ReferenceTimestamp, Base64Body, UnicodeBody, Request, \ - Response + Response, NavigateError from .logger import Logger, Consumer from .devtools import Crashed, Process @@ -74,12 +74,8 @@ async def test_invalidurl (loader): resolved = await loop.getaddrinfo (host, None) except socket.gaierror: url = URL.build (scheme='http', host=host) - await loader.navigate (url) - async for it in loader: - assert it.request is not None - assert it.url == url - assert it.response is None - break + with pytest.raises (NavigateError): + await loader.navigate (url) else: pytest.skip (f'host {host} resolved to {resolved}') -- cgit v1.2.3