summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-01-19player: Avoid deadlockLars-Dominik Braun1-0/+1
When the play thread receives an error (ret < 0), it waits for aoplayCond. But if the buffer is full (decode thread waiting for aoplayCond), the player deadlocks. See #672.
2018-10-15Expose audio buffer size settingLars-Dominik Braun4-2/+9
See issue #672.
2018-10-15Increase max_retries default valueLars-Dominik Braun2-2/+3
Back to default value before ff4f15214100d209f39e4ed85f47e572c8fe9289. It is used by the player as well and since 403’s are considered an “error” it must be larger than the number of files per playlist (4). See issue #672.
2018-09-23Don’t use deprecated ffmpeg functionsLars-Dominik Braun2-4/+32
These are now optional according to doc/APIchanges. Closes #670.
2018-09-15Implement audio bufferingedward-p3-42/+108
Prevent stuttering on low-power devices like Android phones by moving playback to its own thread and decoupling it from decoding through a reasonably sized buffer. Fixes #665.
2018-08-12Improve QuickMix selection error messageLars-Dominik Braun1-3/+3
See #668.
2018-06-26Add GitHub issue templateLars-Dominik Braun1-0/+19
2018-06-22Back to -devLars-Dominik Braun1-1/+1
2018-06-22Release 2018.06.222018.06.22Lars-Dominik Braun2-1/+8
HAPPY 10TH BIRTHDAY PIANOBAR! It’s first public release was created on 2008-06-05. So I’m slightly late to the party. Sorry about that. Also, I never thought a piece of software *I* wrote would last that long.
2018-04-16Remove deprecated header avfiltergraph.hLars-Dominik Braun2-2/+0
Has been merged into avfilter.h. Closes #660.
2018-04-07Add network timeouts and retriesLars-Dominik Braun6-9/+39
All network operations can time out now. API requests are retried up to three times (default). Replaces setting max_player_errors with max_retries, which is used for player and API. Adds timeout setting. Partially reverts 436a1d4012553a2f33d0e3a5180b3b5ae0378bdd and fixes (at least) issue #657. Thanks to @exarkun for testing.
2018-03-15Properly protect player struct with mutexLars-Dominik Braun6-82/+149
The volatile keyword neither guarantees atomic access nor memory visibility[1]. Although this is usually not a problem on x86, it is incorrect to rely on this. Use mutex locks to protect all shared player variables and enforce memory visibility. [1] https://wiki.sei.cmu.edu/confluence/display/c/CON02-C.+Do+not+use+volatile+as+a+synchronization+primitive
2018-01-22contrib: Remove wrong comment about 192k audioLars-Dominik Braun1-2/+0
Closes #634
2018-01-22contrib: Add usage to multi.shLars-Dominik Braun1-2/+12
Closes #648
2017-10-27Corrected markdown linkDanny Lloyd1-2/+1
2017-10-07Fix logic for marking station (deleted)Lars-Dominik Braun1-8/+7
For songs with no station associated (NULL) “(deleted)” was shown unconditionally. Hide it. Fixes commit 4dfca5b56b441faf4938b6c8e97585f68e468039.
2017-10-07piano: Fetch extended attribs for station infoLars-Dominik Braun2-0/+8
We can show the song length in the feedback list now.
2017-10-02Show station in song listsLars-Dominik Braun6-17/+47
Iff song’s station is not the current station. This is only the case for the song history right now. Closes #638
2017-09-30Add tired rating to songLars-Dominik Braun8-13/+46
Now we can show a tired icon in the history. Closes #637.
2017-09-30Add (optional) song duration to song list format stringLars-Dominik Braun2-4/+14
Closes #636.
2017-08-30Back to -devLars-Dominik Braun1-1/+1
2017-08-30Prepare for release 2017.08.302017.08.30Lars-Dominik Braun2-1/+10
2017-04-26eventcmd.sh: Guard against spaces in pathRichard Hartmann1-1/+1
2017-04-26contrib: Use $XDG_HOME_CONFIGLars-Dominik Braun1-1/+1
Fixes #618.
2017-04-26Fix use-after-free when deleting stationLars-Dominik Braun1-0/+2
Eventcmd uses both, selStation and selSong. Fixes #617.
2017-04-06Render actual headingsGaren Torikian1-4/+4
2017-03-25Switch to #pragma onceLars-Dominik Braun10-34/+12
2017-03-25piano: Replace deprecated json_object_object_getLars-Dominik Braun1-74/+105
2017-03-24Replace deprecated avcodec_decode_audio4Lars-Dominik Braun4-76/+74
Use new send_packet/receive_frame API. Bumps libav and ffmpeg version requirements. Revert this commit if you need an older version.
2017-03-17Sort manpage, remove non-existing tls_fingerprintLars-Dominik Braun2-21/+18
2017-03-14Added gain_mul setting to soften effect of replaygain.Sean Greenslade4-2/+12
2016-12-12add uninstall into makefileFelix Wong1-1/+10
2016-12-02Exit when no email/password was entered or ^C was pressedLars-Dominik Braun1-2/+7
Fixes #600.
2016-10-29Replace getline() with fgets()Lars-Dominik Braun1-6/+9
Mac OS X 10.6 compatibility, fixes #572.
2016-10-15Support binding to a specific network interfaceblmpl5-0/+25
Closes #597.
2016-10-15Turn off ffmpeg’s error messagesLars-Dominik Braun1-0/+1
See #577.
2016-06-02Back to -devLars-Dominik Braun1-1/+1
2016-06-02Prepare for release 2016.06.022016.06.02Lars-Dominik Braun2-1/+6
2016-04-14Fix songfinish event when changing stationsLars-Dominik Braun4-25/+30
The event did not contain any song data (title, artist, …), because the playlist was destroyed by the ui command. Now the actual station switch is deferred by introducing nextStation and letting the main loop handle it. Fixes issue #584.
2016-03-05Quit upon reception of two SIGINTLars-Dominik Braun3-10/+20
If player is running one SIGINT restarts current track request, two SIGINT (or more) quit pianobar. Idle main loop (i.e. no player or submenu) quits on SIGINT. Fixes issue #564.
2016-02-21Makefile: Provide a way to disable silent rulesLars-Dominik Braun1-16/+24
Fixes #571
2016-02-11Add default value for rpcTlsPortLars-Dominik Braun2-1/+5
Passing NULL to printf and the result to curl may or may not work. YMMV. Fixes #574.
2015-11-22Back to -devLars-Dominik Braun1-1/+1
2015-11-22Prepare for release 2015.11.222015.11.22Lars-Dominik Braun2-1/+13
2015-10-23Interruptible requestsLars-Dominik Braun9-111/+129
^C now works as expected: It interrupts API requests, input prompts and audio streaming. Timeouts have been removed.
2015-10-06Further Makefile fixesLars-Dominik Braun1-31/+20
Specifically: Use libao’s pkgconfig file, drop explicit header dependencies (handled by dependency generation), use immediate assignment operator :=
2015-10-05clean up MakefileDavid Coppa1-7/+3
2015-09-25settings: Fix config file parserLars-Dominik Braun2-10/+61
scanf’s %s matches non-whitespace characters only and thus ‘# foo = bar’ is parsed as ‘foo’, ‘bar’ and not ‘# foo’, ‘bar’ (as expected). Thus comments did not work if they a) started with a valid key and b) had a space between hash-sign and key. Fixes issue #526.
2015-09-06player: Fix strange volume bugLars-Dominik Braun1-1/+1
On one of my machines the first song plays fine, but every track thereafter fails playing with the following error message: [volume @ 0x7f6b1c0a1200] [Eval @ 0x7f6b21ab6b60] Invalid chars '.0' at the end of expression '1.0' [volume @ 0x7f6b1c0a1200] Error when evaluating the volume expression '1.0' /!\ create_filter volume (Das Argument ist ungültig) I’m not sure why this fixes the issue, but it might be a bug in ffmpeg.
2015-09-06player: Replace deprecated ffmpeg API callsLars-Dominik Braun1-17/+7
A few changes were made to AVFrame and the buffersink. Should be compatible with ffmpeg >= 2.1 and libav >= 10. Version 1.2/9 do not work at this point.
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-25 06:24:01 +0000