From b1ea463843add37874f9768b606825504cdc8eb2 Mon Sep 17 00:00:00 2001 From: Lars-Dominik Braun Date: Fri, 13 Jun 2008 20:39:13 +0200 Subject: Hopefully fixed wrong libxml2 usage We did a xmlCleanupParser () call everytime we finished parsing; this is wrong (http://xmlsoft.org/html/libxml-parser.html#xmlCleanupParser) --- libpiano/main.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'libpiano/main.c') diff --git a/libpiano/main.c b/libpiano/main.c index e475b59..cc4e65a 100644 --- a/libpiano/main.c +++ b/libpiano/main.c @@ -32,7 +32,9 @@ THE SOFTWARE. #include "xml.h" #include "crypt.h" -/* initialize piano handle, set up curl handle and settings +/* initialize piano handle, set up curl handle and settings; note: you + * _must_ init curl and libxml2 using curl_global_init (CURL_GLOBAL_SSL) + * and xmlInitParser (), you also _must_ cleanup their garbage on your own! * @author PromyLOPh * @added 2008-06-05 * @param piano handle @@ -140,7 +142,9 @@ void PianoDestroyPlaylist (PianoHandle_t *ph) { ph->playlist = NULL; } -/* frees the whole piano handle structure +/* frees the whole piano handle structure; this will _not_ cleanup curl's + * internal garbage, you have to call curl_global_cleanup () and + * xmlCleanupParser () for libxml2 * @author PromyLOPh * @added 2008-06-05 * @param piano handle -- cgit v1.2.3