From 7df9371491e96a99c1e463f7787aede352ac5a37 Mon Sep 17 00:00:00 2001 From: Lars-Dominik Braun Date: Fri, 20 Apr 2012 11:49:02 +0200 Subject: Remove pause mutex/add pthread cleanup function No more mutex locking/checking for quit condition. Should (slightly) increase responsiveness of the player thread. Closes #250. --- src/ui_act.c | 25 ++++++++++++++++--------- 1 file changed, 16 insertions(+), 9 deletions(-) (limited to 'src/ui_act.c') diff --git a/src/ui_act.c b/src/ui_act.c index 0c9ed1b..2cc3197 100644 --- a/src/ui_act.c +++ b/src/ui_act.c @@ -23,10 +23,14 @@ THE SOFTWARE. /* functions responding to user's keystrokes */ +#ifndef __FreeBSD__ +#define _POSIX_C_SOURCE 200112L /* pthread_kill() */ +#endif + #include #include -#include #include +#include #include "ui.h" #include "ui_readline.h" @@ -49,10 +53,9 @@ THE SOFTWARE. static inline void BarUiDoSkipSong (struct audioPlayer *player) { assert (player != NULL); - player->doQuit = 1; - /* unlocking an unlocked mutex is forbidden by some implementations */ - pthread_mutex_trylock (&player->pauseMutex); - pthread_mutex_unlock (&player->pauseMutex); + if (player->mode != PLAYER_FINISHED_PLAYBACK && player->mode != PLAYER_FREED) { + pthread_cancel (player->thread); + } } /* transform station if necessary to allow changes like rename, rate, ... @@ -344,9 +347,12 @@ BarUiActCallback(BarUiActMoveSong) { /* pause */ BarUiActCallback(BarUiActPause) { - /* already locked => unlock/unpause */ - if (pthread_mutex_trylock (&app->player.pauseMutex) == EBUSY) { - pthread_mutex_unlock (&app->player.pauseMutex); + if (app->player.paused) { + pthread_kill (app->player.thread, BAR_PLAYER_SIGCONT); + app->player.paused = false; + } else { + pthread_kill (app->player.thread, BAR_PLAYER_SIGSTOP); + app->player.paused = true; } } @@ -489,8 +495,9 @@ BarUiActCallback(BarUiActSelectQuickMix) { /* quit */ BarUiActCallback(BarUiActQuit) { - app->doQuit = 1; + /* cancels player thread */ BarUiDoSkipSong (&app->player); + app->doQuit = 1; } /* song history -- cgit v1.2.3