summaryrefslogtreecommitdiff
path: root/crocoite/util.py
diff options
context:
space:
mode:
authorLars-Dominik Braun <lars@6xq.net>2018-12-25 18:56:55 +0100
committerLars-Dominik Braun <lars@6xq.net>2018-12-25 18:59:55 +0100
commitcc1132a5b4677d089e024bcd0e16e1e817a3581c (patch)
tree8509c3cca27c8c7a2620093f03a3fb4e3bb7e45b /crocoite/util.py
parentf8217408eeea5531b5f4f353b238dc94de705132 (diff)
downloadcrocoite-cc1132a5b4677d089e024bcd0e16e1e817a3581c.tar.gz
crocoite-cc1132a5b4677d089e024bcd0e16e1e817a3581c.tar.bz2
crocoite-cc1132a5b4677d089e024bcd0e16e1e817a3581c.zip
warc: Add tests
Using hyothesis-based testcase generation. This is quite nice compared to manual test data generation, since it catches alot more corner cases (if done right). This commit also fixes a few issues, including: - log records will only be written if the log is nonempty - properly quote packageUrl path’s - drop old thread checking code - use placeholder url for scripts without name
Diffstat (limited to 'crocoite/util.py')
-rw-r--r--crocoite/util.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/crocoite/util.py b/crocoite/util.py
index 5bced53..ded5e99 100644
--- a/crocoite/util.py
+++ b/crocoite/util.py
@@ -22,7 +22,7 @@
Random utility functions
"""
-import random, sys, platform, os, json
+import random, sys, platform, os, json, urllib
from datetime import datetime
import hashlib, pkg_resources
@@ -43,7 +43,7 @@ def packageUrl (path):
"""
Create URL for package data stored into WARC
"""
- return 'urn:' + __package__ + ':' + path
+ return 'urn:' + __package__ + ':' + urllib.parse.quote (path)
async def getFormattedViewportMetrics (tab):
layoutMetrics = await tab.Page.getLayoutMetrics ()